-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #898 Update close icon on upsell banners and admin bar #901
Conversation
@@ -35,7 +35,7 @@ | |||
<?php endif; ?> | |||
<p><?php echo $data['text']; ?></p> | |||
<p class="center txt-center text-center"><a class="imagify-upsell-admin-bar-button" href="<?php echo esc_url( $data['upgrade_link'] ); ?>" target="_blank"><?php echo $data['button_text']; ?></a></p> | |||
<a href="<?php echo esc_url( get_imagify_admin_url( 'dismiss-notice', 'upsell-admin-bar' ) ); ?>" class="imagify-notice-dismiss imagify-upsell-dismiss" title="<?php esc_attr_e( 'Dismiss this notice', 'imagify' ); ?>"><span class="screen-reader-text"><?php esc_html_e( 'Dismiss this notice', 'imagify' ); ?></span></a> | |||
<a href="<?php echo esc_url( get_imagify_admin_url( 'dismiss-notice', 'upsell-admin-bar' ) ); ?>" class="imagify-notice-dismiss imagify-upsell-dismiss notice-dismiss" title="<?php esc_attr_e( 'Dismiss this notice', 'imagify' ); ?>"><span class="screen-reader-text"><?php esc_html_e( 'Dismiss this notice', 'imagify' ); ?></span></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tabrisrp Is there a reason that we didn't remove imagify-upsell-dismiss
here while we removed it in part-upsell.php file?
@Tabrisrp Thanks for the PR. @Tabrisrp Any idea why 2,3 has the icon grey and may be underlined? |
I pushed an update for the CSS for cases 2 and 3. |
Thanks, @Tabrisrp Looks good now. |
Description
Fixes #898
Update close icon to use default icon from WP
Type of change
Detailed scenario
Technical description
Documentation
Updated class used + CSS color
Mandatory Checklist
Code validation
Code style